Avoid allocations in 'Transfer-Encoding: Chunked' check #81253
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #63052 Avoids 3 object allocations: Before: After:
|
| return true; | ||
| } | ||
|
|
||
| if (parent.ContainsParsedValue(KnownHeaders.TransferEncoding.Descriptor, HeaderUtilities.TransferEncodingChunked)) |
There was a problem hiding this comment.
Does ContainsParsedValue perform any other side-effects that this now skips?
There was a problem hiding this comment.
Not as it's currently written - if the value is just "chunked", then that's exactly what you would have seen from non-validated or validated accesses later on anyway.
If we tried being smarter with the above check, e.g. "parse all the values without allocating and look for chunked", then you could introduce subtle differences where a non-validating access would still see the original, non-parsed value. But that is also the whole point of NonValidated so it'd be even more correct IMO.
|
Build failure is known according to Build Analysis |
ghost
locked as resolved and limited conversation to collaborators
2 participants
Fixes #63052
Avoids 3 object allocations:
TransferCodingHeaderValue,HeaderStoreItemInfo, and"chunked"(100 bytes total).This is ~4 % of allocated bytes for a simple YARP request.
Before:
After:
