Use MemoryExtensions.Count in a few places #81325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-meta Issue Detailsnull
|
stephentoub
commented
Jan 29, 2023
| private static int CountOccurrences(string value, string candidate) | ||
| { | ||
| Debug.Assert(candidate != null, "CountOccurrences: Candidate string was null."); | ||
| int index = 0; |
There was a problem hiding this comment.
This looks like a pre-existing bug that I'm assuming hasn't caused any issues due to the text being parsed not starting with a newline.
There was a problem hiding this comment.
@dotnet/ncl, can you confirm I'm correct here that this was a latent benign bug rather than something by design?
stephentoub
commented
Jan 29, 2023
src/libraries/System.Text.Json/src/System/Text/Json/Reader/JsonReaderHelper.cs
Outdated
Show resolved
Hide resolved
|
Improvement on Linux-x64 dotnet/perf-autofiling-issues#12453 |
|
@stephentoub and here is a small regression - dotnet/perf-autofiling-issues#12679 and dotnet/perf-autofiling-issues#12557 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.