Use initialCapacity in ASN.1 templates for some primitives #81626
Conversation
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsIn our ASN.1 templated encoding, we encode managed values with For some primitives types, like an ASN.1 Boolean and ASN.1 Integer (where the integer is known to be a managed For booleans, we know the encoded length is always going to be 3 bytes for DER. For integers (where the backing type is Where possible, let's give these size hints to reduce the initial allocation size. For example, the
|
|
(If we ever get one-shot encoding that can write to a stack buffer, that would obviously be better, but we can do this right now) |
|
Tagging subscribers to this area: @dotnet/area-system-formats-asn1, @vcsjones Issue DetailsIn our ASN.1 templated encoding, we encode managed values with For some primitives types, like an ASN.1 Boolean and ASN.1 Integer (where the integer is known to be a managed For booleans, we know the encoded length is always going to be 3 bytes for DER. For integers (where the backing type is Where possible, let's give these size hints to reduce the initial allocation size. For example, the
|
src/libraries/Common/src/System/Security/Cryptography/Asn1/Pkcs12/MacData.xml.cs
Show resolved
Hide resolved
3 participants
In our ASN.1 templated encoding, we encode managed values with
AsnWriterto determine if they are equal todefaultDerInit.For some primitives types, like an ASN.1 Boolean and ASN.1 Integer (where the integer is known to be a managed
int) this has some waste asAsnWriterhas an initial capacity of 1024 bytes.For booleans, we know the encoded length is always going to be 3 bytes for DER. For integers (where the backing type is
int) we know it will encode to at most 6 bytes.Where possible, let's give these size hints to reduce the initial allocation size. For example, the
Criticalboolean in X.509 extensions has a default. Before and after of encoding a basic constraints extension: