KEMBAR78
Fix FnPtrTypeDesc::GetManagedClassObject by jkotas · Pull Request #82325 · dotnet/runtime · GitHub
Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Feb 17, 2023

The code was missing support for allocating RuntimeType objects on frozen heap

Fixes #82252

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this -- prevents FPs from being moved during GC \ causing GC holes perhaps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic in this method has to be in sync with what GetManagedClassObject returns. If it is not in sync, it will lead to all sorts of problems.

@ghost ghost assigned jkotas Feb 17, 2023
@ghost
Copy link

ghost commented Feb 17, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

The code was missing support for allocating RuntimeType objects on frozen heap

Fixes #82252

Author: jkotas
Assignees: -
Labels:

area-System.Reflection

Milestone: -

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this pattern was recently changed to support frozen heaps, so this copy-paste above was stale.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

Copy link
Contributor

@steveharter steveharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The code was missing support for allocating RuntimeType objects on frozen heap

Fixes dotnet#82252
@BruceForstall
Copy link
Contributor

/azp run runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EgorBo
Copy link
Member

EgorBo commented Feb 18, 2023

Ouch, thanks! It turns out to be a FOH-related issue indeed 😞

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion failed: GCHeapUtilities::GetGCHeap()->IsInFrozenSegment(obj)

4 participants