Add a var_types_classification for simd #82616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
tannergooding
commented
Feb 24, 2023
| inline bool varTypeIsSIMD(T vt) | ||
| { | ||
| #ifdef FEATURE_SIMD | ||
| return ((varTypeClassification[TypeGet(vt)] & VTF_VEC) != 0); |
There was a problem hiding this comment.
An alternative would be: return (TypeGet(vt) >= TYP_SIMD8) && (TypeGet(vt) <= TYP_SIMD32);
I'd expect varTypeClassification to typically be cached though, so I'm operating under the assumption a new classification is "better".
|
Excellent! I've been wondering about this. |
5 tasks
|
This represents a CC. @dotnet/jit-contrib |
BruceForstall
approved these changes
Feb 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.