KEMBAR78
Use Environment.SystemDirectory to get system directory by jkotas · Pull Request #83564 · dotnet/runtime · GitHub
Skip to content

Use Environment.SystemDirectory to get system directory #83564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

Use Environment.SystemDirectory to get system directory #83564

merged 1 commit into from
Mar 17, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 17, 2023

Environment.SystemDirectory is a lot more efficient than Environment.GetFolderPath(System.Environment.SpecialFolder.System).

Contributes to dotnet/aspnetcore#47269

@jkotas
Use Environment.SystemDirectory to get system directory
2f15784 
Environment.SystemDirectory is a lot more efficient than Environment.GetFolderPath(System.Environment.SpecialFolder.System).

Contributes to dotnet/aspnetcore#47269
@jkotas jkotas marked this pull request as ready for review March 17, 2023 01:20
@ghost ghost assigned jkotas Mar 17, 2023
@ghost
Copy link

ghost commented Mar 17, 2023

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

Issue Details

Environment.SystemDirectory is a lot more efficient than Environment.GetFolderPath(System.Environment.SpecialFolder.System).

Contributes to dotnet/aspnetcore#47269

Author: jkotas
Assignees: jkotas
Labels:

area-Extensions-Hosting
Milestone: -

@jkotas jkotas requested a review from eerhardt March 17, 2023 01:21
stephentoub
stephentoub approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a code analysis rule that looks for things that should be replaced with members of Environment. Looks like another one to add.

eerhardt
eerhardt approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks for taking care of this!

@jkotas jkotas merged commit dc5a6c8 into dotnet:main Mar 17, 2023
@jkotas jkotas deleted the system-directory branch March 17, 2023 03:25
@build-analysis build-analysis bot mentioned this pull request Mar 17, 2023
Closed
@eerhardt eerhardt mentioned this pull request Mar 17, 2023
Closed
@eerhardt
Copy link
Member

We already have a code analysis rule that looks for things that should be replaced with members of Environment. Looks like another one to add.

I've opened #83591 for this.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@halter73 halter73 halter73 approved these changes

@stephentoub stephentoub stephentoub approved these changes

@eerhardt eerhardt eerhardt approved these changes

Assignees

@jkotas jkotas

Labels

area-Extensions-Hosting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas @eerhardt @halter73 @stephentoub