Generate SslConnectionInfo.Unix.cs with T4 template #84690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-System.Net.Security
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones Issue DetailsInstead of generating a huge static dictionary and runtime lookup, we can directly generate a switch-case chain.
This PR removes the cctor and inlines the value assignment. It shaves off 18.3 K from the final NativeAOT published binary. # on osx-arm64
# prereqs
## $ dotnet tool install -g dotnet-t4 -a arm64
## $ cd runtime
## $ t4 src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.tt -o src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.cs
# build required subsets to publish CG2 with map file
$ ./build.sh clr+libs+packs -c Release -p:IlcGenerateMapFile=true
# top 50 largest methods
$ xmlstarlet sel -t -m "//ObjectNodes/MethodCode" -v 'concat(@Length, ": ", @Name)' -n artifacts/obj/coreclr/crossgen2/arm64/Release/native/crossgen2.map.xml | sort -nr | head -50
|
am11
added
the
size-reduction
|
Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar Issue DetailsInstead of generating a huge static dictionary and runtime lookup, we can directly generate a switch-case chain.
This PR removes the cctor and inlines the value assignment. It shaves off 18.3 K from the final NativeAOT published binary. # on osx-arm64
# prereqs
## $ dotnet tool install -g dotnet-t4 -a arm64
## $ cd runtime
## $ t4 src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.tt -o src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.cs
# build required subsets to publish CG2 with map file
$ ./build.sh clr+libs+packs -c Release -p:IlcGenerateMapFile=true
# top 50 largest methods
$ xmlstarlet sel -t -m "//ObjectNodes/MethodCode" -v 'concat(@Length, ": ", @Name)' -n artifacts/obj/coreclr/crossgen2/arm64/Release/native/crossgen2.map.xml | sort -nr | head -50
|
rzikm
approved these changes
Apr 13, 2023
MihaZupan
reviewed
Apr 13, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 14, 2023
src/libraries/System.Net.Security/src/System/Net/Security/TlsCipherSuiteNameParser.ttinclude
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 14, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.cs
Outdated
Show resolved
Hide resolved
|
cc @ivanpovazan |
jkotas
reviewed
Apr 15, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.tt
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 15, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.tt
Outdated
Show resolved
Hide resolved
This was referenced Apr 15, 2023
jkotas
reviewed
Apr 16, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 16, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 16, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.tt
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 16, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.tt
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 16, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.tt
Show resolved
Hide resolved
jkotas
reviewed
Apr 16, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.tt
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 16, 2023
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.Unix.tt
Outdated
Show resolved
Hide resolved
|
Looks great otherwise - thank you! |
|
enterprise-linux failure is #84795 |
jkotas
approved these changes
Apr 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating a huge static dictionary and runtime lookup, we can directly generate a switch-case chain.
System_Net_Security_System_Net_Security_TlsCipherSuiteData___cctoris the largest method in terms of code size.This PR removes the cctor and inlines the value assignment. It shaves off 18.3 K from the final NativeAOT published binary.