KEMBAR78
Don't contain operands for intrinsics when generating a jmp table fallback by tannergooding · Pull Request #84933 · dotnet/runtime · GitHub
Skip to content

Don't contain operands for intrinsics when generating a jmp table fallback #84933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2023
Merged

Don't contain operands for intrinsics when generating a jmp table fallback #84933

merged 1 commit into from
Apr 18, 2023

Conversation

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Apr 17, 2023 •
edited
Loading

Noticed this small size win in #84909, it basically just ensures the load is hoisted which can saves us up to 512 bytes per fallback path.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 17, 2023
@tannergooding tannergooding mentioned this pull request Apr 17, 2023
Merged
@tannergooding tannergooding marked this pull request as ready for review April 17, 2023 18:57
@tannergooding
Copy link
Member Author

Diffs

Savings of 120k bytes in FullOpts for Linux x64

@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib

EgorBo
EgorBo approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice diffs!

@tannergooding tannergooding merged commit 769ad43 into dotnet:main Apr 18, 2023
@tannergooding tannergooding deleted the simd-fallback-improv branch April 18, 2023 23:19
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tannergooding @EgorBo