KEMBAR78
Fix JsonNode.To allocations by pentp · Pull Request #85886 · dotnet/runtime · GitHub
Skip to content

Fix JsonNode.To allocations #85886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2023
Merged

Fix JsonNode.To allocations #85886

merged 1 commit into from
May 7, 2023

Conversation

@pentp
Copy link
Contributor

@pentp pentp commented May 7, 2023

JsonHelpers.Utf8GetString takes a ReadOnlySpan<byte> parameter...

@ghost ghost added area-System.Text.Json community-contribution Indicates that the PR has been added by a community member labels May 7, 2023
@ghost
Copy link

ghost commented May 7, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

JsonHelpers.Utf8GetString takes a ReadOnlySpan<byte> parameter...

Author: pentp
Assignees: -
Labels:

area-System.Text.Json, community-contribution
Milestone: -

stephentoub
stephentoub approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@stephentoub stephentoub merged commit b9b5fef into dotnet:main May 7, 2023
@pentp pentp deleted the patch-1 branch May 7, 2023 23:10
@ghost ghost locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

area-System.Text.Json community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pentp @stephentoub