Fold "FrozenObjectHandle(REF) + CNS" to a byref constant #85888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsLet's see if any target complains about it. This removes two "add" instructions from #85880 snippet, or e.g.: ReadOnlySpan<char> Test() => "Hello World"was: ; Method Program:Test():System.ReadOnlySpan`1[ushort]:this
mov rax, 0x14380209280 ; 'Hello World'
add rax, 12
mov edx, 11
ret
; Total bytes of code: 20now: ; Method Program:Test():System.ReadOnlySpan`1[ushort]:this
mov rax, 0x29C8020928C
mov edx, 11
ret
; Total bytes of code: 16
|
jakobbotsch
reviewed
May 7, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run runtime-coreclr outerloop, runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@dotnet/jit-contrib PTAL simple change with nice diffs, outerloop/jitstress/gcstress tests passed |
|
@jakobbotsch PTAL |
jakobbotsch
approved these changes
May 9, 2023
This was referenced May 16, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if any target complains about it. This removes two "add" instructions from #85880 snippet, or e.g.:
was:
now:
Diffs.