KEMBAR78
Simplify Random for ulong by MichalPetryka · Pull Request #87219 · dotnet/runtime · GitHub
Skip to content

Conversation

MichalPetryka
Copy link
Contributor

Use Math.BigMul instead of UInt128 since both values are always ulongs.

Use Math.BigMul instead of UInt128 since both values are always ulongs.
@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners community-contribution Indicates that the PR has been added by a community member labels Jun 7, 2023
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is doing obviously less work and explicitly gives us the two separate parts we end up dealing with anyways.

@vcsjones vcsjones added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 7, 2023
@ghost
Copy link

ghost commented Jun 7, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Use Math.BigMul instead of UInt128 since both values are always ulongs.

Author: MichalPetryka
Assignees: -
Labels:

area-System.Runtime, community-contribution

Milestone: -

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants