Fix WCHAR definition on non-Windows for nativeaot #87465
Conversation
This fixes enabling of runtime events on non-Windows. The GC events that don't go through ETW::GCLog are now fired/collected on non-Windows. There is still work needed to pull in the ETW::GCLog implementation on non-Windows
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsIn combination with #87430, this fixes enabling of runtime events on non-Windows. We were using wchar_t on non-Windows and expecting it to be 2 bytes (when it is 4) - as a result, the string length / conversion functions were not working properly and providers were not properly enabled. The GC events that don't go through ETW::GCLog are now fired/collected on non-Windows. There is still work needed to pull in the ETW::GCLog implementation on non-Windows. Contributes to #87445 cc @LakshanF
|
|
Out of curiosity: I thought WCHAR on Windows is UTF-16. Is it UTF-32 on Linux? I assume these definitions come from our PAL layer. |
|
|
Ugh, missed updating disableddotnetruntime.cpp. PR didn't catch it because it needed to have #87430. |
|
https://github.com/dotnet/runtime/pull/87509/files should fix it. |
ghost
locked as resolved and limited conversation to collaborators
4 participants
In combination with #87430, this fixes enabling of runtime events on non-Windows. We were using wchar_t on non-Windows and expecting it to be 2 bytes (when it is 4) - as a result, the string length / conversion functions were not working properly and providers were not properly enabled.
The GC events that don't go through ETW::GCLog are now fired/collected on non-Windows. There is still work needed to pull in the ETW::GCLog implementation on non-Windows.
Contributes to #87445
cc @LakshanF