Remove unnecessary closures from Logging{Scope}HttpMessageHandler.SendCoreAsync #89160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThe local async function is closing over the outer private Task<HttpResponseMessage> SendCoreAsync(HttpRequestMessage request, bool useAsync, CancellationToken cancellationToken)
{
<>c__DisplayClass5_0 <>c__DisplayClass5_ = new <>c__DisplayClass5_0();
<>c__DisplayClass5_.<>4__this = this;
<>c__DisplayClass5_.useAsync = useAsync;
System.ThrowHelper.ThrowIfNull(request, "request");
return <>c__DisplayClass5_.<SendCoreAsync>g__Core|0(request, cancellationToken);
}and with this change now looks like: private Task<HttpResponseMessage> SendCoreAsync(HttpRequestMessage request, bool useAsync, CancellationToken cancellationToken)
{
System.ThrowHelper.ThrowIfNull(request, "request");
return <SendCoreAsync>g__Core|5_0(request, useAsync, cancellationToken);
}
|
davidfowl
approved these changes
Jul 19, 2023
This was referenced Jul 19, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local async function is closing over the outer
useAsyncparameter, and because it's an async method, that closure is a class. Thus the decompiled method previously looked like:and with this change now looks like: