KEMBAR78
Add diagnostic when the size of an array that is marshalled to the callee is an 'out' parameter. by jtschuster · Pull Request #89827 · dotnet/runtime · GitHub
Skip to content

Conversation

@jtschuster
Copy link
Member

@jtschuster jtschuster commented Aug 2, 2023

Fixes #87081 for single dimensional arrays. 2D arrays may have an out count parameter for IndirectionLevel > 0, but this is uncommon and the solution would add significant complexity and overhead.

@ghost
Copy link

ghost commented Aug 2, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #87081.

Author: jtschuster
Assignees: -
Labels:

area-System.Runtime.InteropServices

Milestone: -

@jtschuster jtschuster marked this pull request as ready for review August 2, 2023 20:01
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of my offline feedback looks to be addressed. LGTM!

@jtschuster jtschuster merged commit 45e1e2c into dotnet:main Aug 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interop Generators don't warn when CountElementName for parameter array is an out parameter

2 participants