Remove use of string.Split from reflection
#95952
Conversation
Saves 1.2% on a Hello World. `dotnet new console --aot && dotnet publish /p:OptimizationPreference=Size` is now under 1 MB. This is actually also a throughput optimization, not just size optimization.
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsSaves 1.2% on a Hello World. This is actually also a throughput optimization, not just size optimization. Cc @dotnet/ilc-contrib
|
...Lib/src/System/Reflection/Runtime/TypeInfos/NativeFormat/NativeFormatRuntimeNamedTypeInfo.cs
Outdated
Show resolved
Hide resolved
|
For best throughput you should probably move the collection literal out of the loop as it otherwise constructs an inline array on every iteration |
This would be an optimization on average only if there are more types with at least two attributes than there are types with no attributes. In any case, it would be very minor optimization, if at all. Constructing the inline array is very cheap. I think it is fine as-is for better readability. |
5 participants
Saves 1.2% on a Hello World.
dotnet new console --aot && dotnet publish /p:OptimizationPreference=Sizeis now under 1 MB.This is actually also a throughput optimization, not just size optimization.
Cc @dotnet/ilc-contrib