KEMBAR78
Added LeetCode Icon to SuperTinyIcons by sujal-thakur01 · Pull Request #809 · edent/SuperTinyIcons · GitHub
Skip to content

Conversation

sujal-thakur01
Copy link

This PR adds the LeetCode icon to the SuperTinyIcons collection. The icon is under 1KB in size and follows the guidelines. Perfect for lightweight use cases where minimal file size is crucial!

@edent
Copy link
Owner

edent commented Sep 30, 2024

Did you use AI for this?

The icon is you have provided is 4.09 KB.

You can either resubmit following the guidelines, or have the Hacktoberfest spam label applied. Your choice.

Guidelines at https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md

@sujal-thakur01
Copy link
Author

I have optimised the LeetCode icon following the contribution guidelines, and it is now under 1024 bytes.

Please review the changes. Thank you!

@edent edent added the spam label Sep 30, 2024
@edent
Copy link
Owner

edent commented Sep 30, 2024

Please do not send spammy Pull Requests. I gave you very clear guidelines which you ignored. You used AI inappropriately. This is not the way to behave. Do better.

@edent edent closed this Sep 30, 2024
@sujal-thakur01
Copy link
Author

Could you please explain me where did I went wrong so that I can improve on that and do the changes?... because I clearly didn't understand

@edent
Copy link
Owner

edent commented Oct 1, 2024

@techbro815 your first attempt at the PR was written by AI. I can tell by the difference in writing style.

There are very clear guidelines at https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md

They say the icon has to be under 1,024 bytes. Your icon was over 4KB.

They say how the SVG should be laid out. You ignored that.

The icon you finally provided didn't look like the original icon.

@sujal-thakur01
Copy link
Author

@edent I completely agree with you and that's a huge blunder from my end but I am a freshie here, very new to open source... Can you please remove the spam filter from
me?... I'll make sure from next time that I go through each and every guideline and use AI only for reference

@edent
Copy link
Owner

edent commented Oct 1, 2024

@techbro815

  1. Stop using AI. You need to learn this yourself. Do not use it for reference. It cannot help you.
  2. Read the Contributing guide. If it isn't clear, ask me a question.
  3. If you can submit a compliant icon, which follows the guide, I'll remove the spam label.

@sujal-thakur01
Copy link
Author

@edent
Okay sure for sure I'll keep these points in mind and definitely do the needful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants