-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
Closed
Labels
Description
Describe the bug
The package.json file for eslint-config-react-app differs between NPM and Git for one peer dependency:
- Git:
"eslint-plugin-react-hooks": "1.x || 2.x || 3.x || 4.x" - Npm:
"eslint-plugin-react-hooks": "1.x || 2.x"
Both has "version": "5.2.1", and everything else matches, except for this one peer dependency. 😕
Steps to reproduce
- Inspect package.json on git:
✔"version": "5.2.1"
✔"eslint-plugin-react-hooks": "1.x || 2.x || 3.x || 4.x" - Run
npm pack eslint-config-react-app - Inspect the
package.jsonwithin the downloadedtgzpackage:
✔"version": "5.2.1"
❌"eslint-plugin-react-hooks": "1.x || 2.x"
Expected behavior
Would expect the acceptable versions of "eslint-plugin-react-hooks" to be the same in both places.
Actual behavior
Acceptable versions do not match. Means npm gives me a warning when I try to upgrade eslint-plugin-react-hooks to its latest version, 4.x:
> npm install eslint-plugin-react-hooks@4
npm WARN eslint-config-react-app@5.2.1 requires a peer of eslint-plugin-react-hooks@1.x || 2.x but none is installed. You must install peer dependencies yourself.
+ eslint-plugin-react-hooks@4.0.1
updated 1 package and audited 712 packages in 3.669s
xoddong, rtalexk, run-time, ztc212, vdumitraskovic and 11 more