Minor refactors in create-react-app #8178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Inline errorLogFilePatterns; it's only ever used here. - Alphabetize validFiles. - Simplify log file removal code. - Move unconditional console.log() call outside of the function. This keeps output roughly the same in the common case.
It's not obvious why this code exists, so I made the code a little more obvious and added a comment.
- Inline printValidationResults. - Standardize the output on failure. Manually verified the output looks nice!
heyimalex
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
mrmckeb
approved these changes
Dec 15, 2019
|
Good pickup! |
iansu
approved these changes
Dec 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some things I noticed going through the code last weekend. I tried to keep the commits pretty piecemeal.