Make debugger work with requests spawned with xbox_task_start

ebluestein · fredemmott · commit 572d75b337e9 · 2018-07-12T12:47:25.000-07:00
Summary: The debugger was not attaching to these requests, meaning that while they can hit hphp_debug_break breakpoints, they can't step or hit regular breakpoints. Fixing github issue #8218 (comment) Reviewed By: alexmalyshev Differential Revision: D8730411 fbshipit-source-id: c35f922aab35e2ed04263649740110b3c2931877
diff --git a/hphp/runtime/server/rpc-request-handler.cpp b/hphp/runtime/server/rpc-request-handler.cpp
@@ -34,7 +34,6 @@
 #include "hphp/runtime/server/satellite-server.h"
 #include "hphp/runtime/server/server-stats.h"
 #include "hphp/runtime/server/source-root-info.h"
-#include "hphp/runtime/vm/debugger-hook.h"
 #include "hphp/runtime/vm/vm-regs.h"
 #include "hphp/runtime/vm/treadmill.h"
 
@@ -310,10 +309,6 @@ bool RPCRequestHandler::executePHPFunction(Transport *transport,
   }
   int output = transport->getIntParam("output", requestMethod);
 
-  // We don't debug RPC requests, so we need to detach the installed debugger
-  // hook (only if there is one).
-  DEBUGGER_ATTACHED_ONLY(DebuggerHook::detach());
-
   int code;
   if (!error) {
     Variant funcRet;
