Reverse result list at the end of ignore_toplevel

vladima · fredemmott · commit 864c84c890ff · 2018-01-29T13:39:43.000-08:00
Summary: `ignore_toplevel` is structured similar to `toplevel` however it does not reverse result list and thus returns results in wrong order. This messes up other things downstream in FFP integration work.

Differential Revision: D6656918
diff --git a/hphp/hack/src/parser/parser_hack.ml b/hphp/hack/src/parser/parser_hack.ml
@@ -549,7 +549,7 @@ and ignore_toplevel attr_start ~attr acc env terminate =
   match L.token env.file env.lb with
   | x when terminate x || x = Teof ->
       L.back env.lb;
-      acc
+      List.rev acc
   | Tltlt ->
       (* Parsing attribute << .. >> *)
       (* TODO: error for repeated attribute list *)
@@ -621,7 +621,7 @@ and ignore_toplevel attr_start ~attr acc env terminate =
       )
   | Tclose_php ->
       error env "Hack does not allow the closing ?> tag";
-      acc
+      List.rev acc
   | _ ->
       (* All the other statements. *)
       ignore_toplevel None ~attr:[] acc env terminate
