Support Flow as expressions in ESLint rules

gkz · gkz · commit 2aa5b4dd1fae · 2023-10-25T16:38:15.000-07:00
diff --git a/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js b/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js
@@ -177,7 +177,7 @@ export default {
         if (init == null) {
           return false;
         }
-        while (init.type === 'TSAsExpression') {
+        while (init.type === 'TSAsExpression' || init.type === 'AsExpression') {
           init = init.expression;
         }
         // Detect primitive constants
@@ -1520,7 +1520,7 @@ function getConstructionExpressionType(node) {
       }
       return null;
     case 'TypeCastExpression':
-      return getConstructionExpressionType(node.expression);
+    case 'AsExpression':
     case 'TSAsExpression':
       return getConstructionExpressionType(node.expression);
   }
diff --git a/scripts/eslint-rules/safe-string-coercion.js b/scripts/eslint-rules/safe-string-coercion.js
@@ -291,7 +291,11 @@ function checkBinaryExpression(context, node) {
     (isEmptyLiteral(node.left) || isEmptyLiteral(node.right))
   ) {
     let valueToTest = isEmptyLiteral(node.left) ? node.right : node.left;
-    if (valueToTest.type === 'TypeCastExpression' && valueToTest.expression) {
+    if (
+      (valueToTest.type === 'TypeCastExpression' ||
+        valueToTest.type === 'AsExpression') &&
+      valueToTest.expression
+    ) {
       valueToTest = valueToTest.expression;
     }
 
