Remove argument committedLanes from reappearLayoutEffects and recursivelyTraverseReappearLayoutEffects (#25080)

sammy-SC · web-flow · commit 7bcc687720bb · 2022-08-11T14:24:56.000+01:00
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js
@@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber(
             recursivelyTraverseReappearLayoutEffects(
               finishedRoot,
               finishedWork,
-              committedLanes,
               includeWorkInProgressEffects,
             );
           } else {
@@ -2704,7 +2703,6 @@ function reappearLayoutEffects(
   finishedRoot: FiberRoot,
   current: Fiber | null,
   finishedWork: Fiber,
-  committedLanes: Lanes,
   // This function visits both newly finished work and nodes that were re-used
   // from a previously committed tree. We cannot check non-static flags if the
   // node was reused.
@@ -2719,7 +2717,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
       // TODO: Check flags & LayoutStatic
@@ -2730,7 +2727,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
 
@@ -2772,7 +2768,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
 
@@ -2792,7 +2787,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
       // TODO: Figure out how Profiler updates should work with Offscreen
@@ -2805,7 +2799,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
 
@@ -2825,7 +2818,6 @@ function reappearLayoutEffects(
         recursivelyTraverseReappearLayoutEffects(
           finishedRoot,
           finishedWork,
-          committedLanes,
           includeWorkInProgressEffects,
         );
       }
@@ -2835,7 +2827,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
       break;
@@ -2846,7 +2837,6 @@ function reappearLayoutEffects(
 function recursivelyTraverseReappearLayoutEffects(
   finishedRoot: FiberRoot,
   parentFiber: Fiber,
-  committedLanes: Lanes,
   includeWorkInProgressEffects: boolean,
 ) {
   // This function visits both newly finished work and nodes that were re-used
@@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects(
       finishedRoot,
       current,
       child,
-      committedLanes,
       childShouldIncludeWorkInProgressEffects,
     );
     child = child.sibling;
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js
@@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber(
             recursivelyTraverseReappearLayoutEffects(
               finishedRoot,
               finishedWork,
-              committedLanes,
               includeWorkInProgressEffects,
             );
           } else {
@@ -2704,7 +2703,6 @@ function reappearLayoutEffects(
   finishedRoot: FiberRoot,
   current: Fiber | null,
   finishedWork: Fiber,
-  committedLanes: Lanes,
   // This function visits both newly finished work and nodes that were re-used
   // from a previously committed tree. We cannot check non-static flags if the
   // node was reused.
@@ -2719,7 +2717,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
       // TODO: Check flags & LayoutStatic
@@ -2730,7 +2727,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
 
@@ -2772,7 +2768,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
 
@@ -2792,7 +2787,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
       // TODO: Figure out how Profiler updates should work with Offscreen
@@ -2805,7 +2799,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
 
@@ -2825,7 +2818,6 @@ function reappearLayoutEffects(
         recursivelyTraverseReappearLayoutEffects(
           finishedRoot,
           finishedWork,
-          committedLanes,
           includeWorkInProgressEffects,
         );
       }
@@ -2835,7 +2827,6 @@ function reappearLayoutEffects(
       recursivelyTraverseReappearLayoutEffects(
         finishedRoot,
         finishedWork,
-        committedLanes,
         includeWorkInProgressEffects,
       );
       break;
@@ -2846,7 +2837,6 @@ function reappearLayoutEffects(
 function recursivelyTraverseReappearLayoutEffects(
   finishedRoot: FiberRoot,
   parentFiber: Fiber,
-  committedLanes: Lanes,
   includeWorkInProgressEffects: boolean,
 ) {
   // This function visits both newly finished work and nodes that were re-used
@@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects(
       finishedRoot,
       current,
       child,
-      committedLanes,
       childShouldIncludeWorkInProgressEffects,
     );
     child = child.sibling;
