...and fix it again

acdlite · acdlite · commit 99dc7a93e55a · 2021-02-11T16:11:13.000-06:00
diff --git a/packages/react-reconciler/src/ReactFiber.new.js b/packages/react-reconciler/src/ReactFiber.new.js
@@ -289,12 +289,7 @@ export function createWorkInProgress(current: Fiber, pendingProps: any): Fiber {
 
   // Reset all effects except static ones.
   // Static effects are not specific to a render.
-  // FIXME: I intentionally broke this to confirm that it triggers a warning
-  // in dev. We should not reset the whole `flags` bitmask; we should preserve
-  // the static flags.
-  // workInProgress.flags = current.flags & StaticMask;
-  workInProgress.flags = NoFlags;
-
+  workInProgress.flags = current.flags & StaticMask;
   workInProgress.childLanes = current.childLanes;
   workInProgress.lanes = current.lanes;
 
diff --git a/packages/react-reconciler/src/ReactFiber.old.js b/packages/react-reconciler/src/ReactFiber.old.js
@@ -289,12 +289,7 @@ export function createWorkInProgress(current: Fiber, pendingProps: any): Fiber {
 
   // Reset all effects except static ones.
   // Static effects are not specific to a render.
-  // FIXME: I intentionally broke this to confirm that it triggers a warning
-  // in dev. We should not reset the whole `flags` bitmask; we should preserve
-  // the static flags.
-  // workInProgress.flags = current.flags & StaticMask;
-  workInProgress.flags = NoFlags;
-
+  workInProgress.flags = current.flags & StaticMask;
   workInProgress.childLanes = current.childLanes;
   workInProgress.lanes = current.lanes;
 
