KEMBAR78
Comparing 128abcfa...84af9085 · facebook/react · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 128abcfa
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 84af9085
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Sep 17, 2025

  1. Log Performance Track Entries for View Transitions (#34510)

    Stacked on #34509.
    
    View Transitions introduces a bunch of new types of gaps in the commit
    phase which needs to be logged differently in the performance track.
    
    One thing that can happen is that a `flushSync` update forces the View
    Transition to abort before it has started if it happens in the gap
    before the transition is ready. In that case we log "Interrupted View
    Transition".
    
    Otherwise, when we're done in `startViewTransition` there's some work to
    finalize the animations before the `ready` calllback. This is logged as
    "Starting Animation".
    
    Then there's a gap before the passive effects fire which we log as
    "Animating". This can be long unless they're forced to flush early e.g.
    due to another lane updating.
    
    The "Animating" track should then pick up which doesn't do yet. This one
    is tricky because this is after the actual commit phase and needs to be
    interrupted by new renders which themselves can be suspended on the
    animation finshing.
    
    This PR is just a subset of all the cases. Will need a lot more work.
    
    <img width="679" height="161" alt="Screenshot 2025-09-16 at 10 19 06 PM"
    src="https://github.com/user-attachments/assets/0407372d-aaed-41f5-a262-059b2686ae87"
    />
    sebmarkbage authored Sep 17, 2025
    Configuration menu
    Copy the full SHA
    84af908 View commit details
    Browse the repository at this point in the history
Loading