-
Notifications
You must be signed in to change notification settings - Fork 49.6k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5e0c951b
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 128abcfa
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 26 files changed
- 3 contributors
Commits on Sep 16, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 851bad0 - Browse repository at this point
Copy the full SHA 851bad0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 941cd80 - Browse repository at this point
Copy the full SHA 941cd80View commit details -
Configuration menu - View commit details
-
Copy full SHA for a51f925 - Browse repository at this point
Copy the full SHA a51f925View commit details -
[compiler] Option to treat "set-" prefixed callees as setState functi…
…ons (#34505) Calling setState functions during render can lead to extraneous renders or even infinite loops. We also have runtime detection for loops, but static detection is obviously even better. This PR adds an option to infer identifers as setState functions if both the following conditions are met: - The identifier is named starting with "set" - The identifier is used as the callee of a call expression By inferring values as SetState type, this allows our existing ValidateNoSetStateInRender rule to flag calls during render, disallowing examples like the following: ```js function Component({setParentState}) { setParentState(...); ^^^^^^^^^^^^^^ Error: Cannot call setState in render } ```
Configuration menu - View commit details
-
Copy full SHA for 7899729 - Browse repository at this point
Copy the full SHA 7899729View commit details
Commits on Sep 17, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 16df13b - Browse repository at this point
Copy the full SHA 16df13bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a4c8f5 - Browse repository at this point
Copy the full SHA 6a4c8f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81d6692 - Browse repository at this point
Copy the full SHA 81d6692View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27b4076 - Browse repository at this point
Copy the full SHA 27b4076View commit details -
Ensure Performance Track are Clamped and Don't overlap (#34509)
This simplifies the logic for clamping the start times of various phases. Instead of checking in multiple places I ensure we compute a value for each phase that is then clamped to the next phase so they don't overlap. If they're zero they're not printed. I also added a name for all the anonymous labels. Those are mainly fillers for sync work that should be quick but it helps debugging if we can name them. Finally the real fix is to update the clamp time which previously could lead to overlapping entries for consecutive updates when a previous update never finalized before the next update.
Configuration menu - View commit details
-
Copy full SHA for e3c9656 - Browse repository at this point
Copy the full SHA e3c9656View commit details -
Configuration menu - View commit details
-
Copy full SHA for 128abcf - Browse repository at this point
Copy the full SHA 128abcfView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 5e0c951b...128abcfa