KEMBAR78
Comparing 5e0c951b...128abcfa · facebook/react · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5e0c951b
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 128abcfa
Choose a head ref
  • 10 commits
  • 26 files changed
  • 3 contributors

Commits on Sep 16, 2025

  1. Configuration menu
    Copy the full SHA
    851bad0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    941cd80 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a51f925 View commit details
    Browse the repository at this point in the history
  4. [compiler] Option to treat "set-" prefixed callees as setState functi…

    …ons (#34505)
    
    Calling setState functions during render can lead to extraneous renders
    or even infinite loops. We also have runtime detection for loops, but
    static detection is obviously even better.
    
    This PR adds an option to infer identifers as setState functions if both
    the following conditions are met:
    - The identifier is named starting with "set"
    - The identifier is used as the callee of a call expression
    
    By inferring values as SetState type, this allows our existing
    ValidateNoSetStateInRender rule to flag calls during render, disallowing
    examples like the following:
    
    ```js
    function Component({setParentState}) {
      setParentState(...);
      ^^^^^^^^^^^^^^ Error: Cannot call setState in render
    }
    ```
    josephsavona authored Sep 16, 2025
    Configuration menu
    Copy the full SHA
    7899729 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2025

  1. Configuration menu
    Copy the full SHA
    16df13b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a4c8f5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81d6692 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    27b4076 View commit details
    Browse the repository at this point in the history
  5. Ensure Performance Track are Clamped and Don't overlap (#34509)

    This simplifies the logic for clamping the start times of various
    phases. Instead of checking in multiple places I ensure we compute a
    value for each phase that is then clamped to the next phase so they
    don't overlap. If they're zero they're not printed.
    
    I also added a name for all the anonymous labels. Those are mainly
    fillers for sync work that should be quick but it helps debugging if we
    can name them.
    
    Finally the real fix is to update the clamp time which previously could
    lead to overlapping entries for consecutive updates when a previous
    update never finalized before the next update.
    sebmarkbage authored Sep 17, 2025
    Configuration menu
    Copy the full SHA
    e3c9656 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    128abcf View commit details
    Browse the repository at this point in the history
Loading