[Flight] Pass line/column to filterStackFrame
#33707
Merged
+27
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
changed the title
filterStackFrame
github-actions
bot
added
the
React Core Team
|
Comparing: 9a645e1...28b08da Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Jul 5, 2025
sebmarkbage
reviewed
Jul 5, 2025
eps1lon
force-pushed
the
sebbie/filterstackframe-indexsourcemap
branch
2 times, most recently
from
27aa4d1 to
8c852b6
Compare
eps1lon
force-pushed
the
sebbie/filterstackframe-indexsourcemap
branch
from
8c852b6 to
28b08da
Compare
This was referenced Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #33706
filterStackFrameimplementations can fast-path ignore-listing by checking if the corresponding source map ignore-lists everything. However, this check requires checking every section for Index Source Maps which deopts the fast-path check from a constant check (comparing.length) to looping through every section (i.e.O(N)).By passing in the relevant line and column, a
filterStackFrameimplementation can find the relevant section with binary search (O(log N)) e.g. https://github.com/vercel/next.js/blob/cc27c243af15703ee4f1bce2dd0afa6960a0f011/packages/next/src/server/lib/source-maps.ts#L60-L82