KEMBAR78
[DevTools] Preserve Suspense lineage when clicking through breadcrumbs by eps1lon · Pull Request #34422 · facebook/react · GitHub
Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Sep 8, 2025

Moves timeline and lineage into state so that we can better reconcile them during Suspense tree changes.

That state could live in TreeStateContext given that we always change inspected Suspense and Element ID together in the Suspense Tab. They're still split for now to avoid re-renders of the Suspense Tab when we're changing Components tab state. Bug mid term they probably end up together. Especially once we implement selecting the nearest Suspense boundary of the inspected Element when navigating to the Suspense tab.

CleanShot.2025-09-09.at.11.11.21.mp4

@meta-cla meta-cla bot added the CLA Signed label Sep 8, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Sep 8, 2025
@eps1lon eps1lon force-pushed the sebbie/09-08-_devtools_preserve_suspense_lineage_when_clicking_through_suspense_breadcrumbs branch from 541d5e8 to 252c8e7 Compare September 8, 2025 21:07
@eps1lon eps1lon requested a review from hoxyq September 9, 2025 09:16
@eps1lon eps1lon marked this pull request as ready for review September 9, 2025 09:17
@eps1lon eps1lon force-pushed the sebbie/09-08-_devtools_preserve_suspense_lineage_when_clicking_through_suspense_breadcrumbs branch 3 times, most recently from 57322f4 to d381773 Compare September 10, 2025 10:10
@eps1lon eps1lon force-pushed the sebbie/09-08-_devtools_preserve_suspense_lineage_when_clicking_through_suspense_breadcrumbs branch from d381773 to cde1a32 Compare September 10, 2025 10:19
@eps1lon eps1lon merged commit 8c15014 into facebook:main Sep 11, 2025
241 checks passed
@eps1lon eps1lon deleted the sebbie/09-08-_devtools_preserve_suspense_lineage_when_clicking_through_suspense_breadcrumbs branch September 11, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants