[DevTools] Unmount fallbacks in the context of the parent Suspense #34475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
e.g. if you have a Fragment
eps1lon
force-pushed
the
sebbie/unmount-suspense
branch
from
2a57992 to
253fb90
Compare
sebmarkbage
approved these changes
Sep 12, 2025
This was referenced Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mount and update fallbacks in the context of the parent Suspense so we need to do the same for the unmount path.
Disconnects we don't need to handle because we keep Suspense nodes in disconnected trees.
Closes #34473 (the failure was unrelated to Activity. I verified that the test in that PR also passes).