const and explicit

fandreuz · fandreuz · commit f6041913bd81 · 2025-06-19T01:47:50.000+02:00
diff --git a/src/callTraceStorage.cpp b/src/callTraceStorage.cpp
@@ -45,19 +45,19 @@ class LongHashTable {
         return prev;
     }
 
-    size_t usedMemory() {
+    size_t usedMemory() const {
         return getSize(_capacity);
     }
 
-    LongHashTable* prev() {
+    LongHashTable* prev() const {
         return _prev;
     }
 
-    u32 capacity() {
+    u32 capacity() const {
         return _capacity;
     }
 
-    u32 size() {
+    u32 size() const {
         return _size;
     }
 
diff --git a/src/flightRecorder.cpp b/src/flightRecorder.cpp
@@ -88,7 +88,7 @@ class MethodInfo {
     jvmtiLineNumberEntry* _line_number_table;
     FrameTypeId _type;
 
-    jint getLineNumber(jint bci) {
+    jint getLineNumber(jint bci) const {
         if (_line_number_table_size == 0) {
             return 0;
         }
@@ -661,7 +661,7 @@ class Recording {
         return _master_recording_file != NULL;
     }
 
-    void appendRecording(const char* target_file, size_t size) {
+    void appendRecording(const char* target_file, size_t size) const {
         int append_fd = open(target_file, O_WRONLY);
         if (append_fd >= 0) {
             lseek(append_fd, 0, SEEK_END);
@@ -755,7 +755,7 @@ class Recording {
         }
     }
 
-    void writeHeader(Buffer* buf) {
+    void writeHeader(Buffer* buf) const {
         buf->put("FLR\0", 4);            // magic
         buf->put16(2);                   // major
         buf->put16(0);                   // minor
@@ -771,7 +771,7 @@ class Recording {
         buf->put32(1);                   // features
     }
 
-    void writeMetadata(Buffer* buf) {
+    void writeMetadata(Buffer* buf) const {
         int metadata_start = buf->skip(5);  // size will be patched later
         buf->putVar32(T_METADATA);
         buf->putVar64(_start_ticks);
@@ -789,7 +789,7 @@ class Recording {
         buf->putVar32(metadata_start, buf->offset() - metadata_start);
     }
 
-    void writeElement(Buffer* buf, const Element* e) {
+    void writeElement(Buffer* buf, const Element* e) const {
         buf->putVar32(e->_name);
 
         buf->putVar32(e->_attributes.size());
@@ -804,7 +804,7 @@ class Recording {
         }
     }
 
-    void writeRecordingInfo(Buffer* buf) {
+    void writeRecordingInfo(Buffer* buf) const {
         int start = buf->skip(1);
         buf->put8(T_ACTIVE_RECORDING);
         buf->putVar64(_start_ticks);
@@ -892,7 +892,7 @@ class Recording {
         }
     }
 
-    void writeOsCpuInfo(Buffer* buf) {
+    void writeOsCpuInfo(Buffer* buf) const {
         struct utsname u;
         if (uname(&u) != 0) {
             return;
diff --git a/src/frameName.cpp b/src/frameName.cpp
@@ -141,7 +141,7 @@ const char* FrameName::decodeNativeSymbol(const char* name) {
     }
 }
 
-const char* FrameName::typeSuffix(FrameTypeId type) {
+const char* FrameName::typeSuffix(FrameTypeId type) const {
     if (_style & STYLE_ANNOTATE) {
         switch (type) {
             case FRAME_INTERPRETED:  return "_[0]";
diff --git a/src/frameName.h b/src/frameName.h
@@ -68,7 +68,7 @@ class FrameName {
 
     void buildFilter(std::vector<Matcher>& vector, const char* base, int offset);
     const char* decodeNativeSymbol(const char* name);
-    const char* typeSuffix(FrameTypeId type);
+    const char* typeSuffix(FrameTypeId type) const;
     void javaMethodName(jmethodID method);
     void javaClassName(const char* symbol, size_t length, int style);
 
diff --git a/src/instrument.cpp b/src/instrument.cpp
@@ -43,11 +43,11 @@ class Constant {
     u8 _info[2];
 
   public:
-    u8 tag() {
+    u8 tag() const {
         return _tag;
     }
 
-    int slots() {
+    int slots() const {
         return _tag == CONSTANT_Long || _tag == CONSTANT_Double ? 2 : 1;
     }
 
diff --git a/src/j9WallClock.cpp b/src/j9WallClock.cpp
@@ -31,7 +31,7 @@ void J9WallClock::stop() {
     pthread_join(_thread, NULL);
 }
 
-void J9WallClock::timerLoop() {
+void J9WallClock::timerLoop() const {
     JNIEnv* jni = VM::attachThread("Async-profiler Sampler");
     jvmtiEnv* jvmti = VM::jvmti();
 
diff --git a/src/j9WallClock.h b/src/j9WallClock.h
@@ -23,7 +23,7 @@ class J9WallClock : public Engine {
         return NULL;
     }
 
-    void timerLoop();
+    void timerLoop() const;
 
   public:
     const char* type() {
diff --git a/src/linearAllocator.cpp b/src/linearAllocator.cpp
@@ -57,7 +57,7 @@ void* LinearAllocator::alloc(size_t size) {
     return NULL;
 }
 
-Chunk* LinearAllocator::allocateChunk(Chunk* current) {
+Chunk* LinearAllocator::allocateChunk(Chunk* current) const {
     Chunk* chunk = (Chunk*)OS::safeAlloc(_chunk_size);
     if (chunk != NULL) {
         chunk->prev = current;
@@ -66,7 +66,7 @@ Chunk* LinearAllocator::allocateChunk(Chunk* current) {
     return chunk;
 }
 
-void LinearAllocator::freeChunk(Chunk* current) {
+void LinearAllocator::freeChunk(Chunk* current) const {
     OS::safeFree(current, _chunk_size);
 }
 
diff --git a/src/linearAllocator.h b/src/linearAllocator.h
@@ -22,8 +22,8 @@ class LinearAllocator {
     Chunk* _tail;
     Chunk* _reserve;
 
-    Chunk* allocateChunk(Chunk* current);
-    void freeChunk(Chunk* current);
+    Chunk* allocateChunk(Chunk* current) const;
+    void freeChunk(Chunk* current) const;
     void reserveChunk(Chunk* current);
     Chunk* getNextChunk(Chunk* current);
 
diff --git a/src/perfEvents_linux.cpp b/src/perfEvents_linux.cpp
@@ -499,7 +499,7 @@ class RingBuffer {
     unsigned long _offset;
 
   public:
-    RingBuffer(struct perf_event_mmap_page* page) {
+    explicit RingBuffer(struct perf_event_mmap_page* page) {
         _start = (const char*)page + OS::page_size;
     }
 
diff --git a/src/symbols_linux.cpp b/src/symbols_linux.cpp
@@ -92,7 +92,7 @@ class SymbolDesc {
     const char* _desc;
 
   public:
-      SymbolDesc(const char* s) {
+      explicit SymbolDesc(const char* s) {
           _addr = s;
           _desc = strchr(_addr, ' ');
       }
@@ -113,7 +113,7 @@ class MemoryMapDesc {
     const char* _file;
 
   public:
-      MemoryMapDesc(const char* s) {
+      explicit MemoryMapDesc(const char* s) {
           _addr = s;
           _end = strchr(_addr, '-') + 1;
           _perm = strchr(_end, ' ') + 1;
@@ -267,8 +267,8 @@ class ElfParser {
     void parseDwarfInfo();
     uint32_t getSymbolCount(uint32_t* gnu_hash);
     void loadSymbols(bool use_debug);
-    bool loadSymbolsFromDebug(const char* build_id, const int build_id_len);
-    bool loadSymbolsFromDebuginfodCache(const char* build_id, const int build_id_len);
+    bool loadSymbolsFromDebug(const char* build_id, int build_id_len);
+    bool loadSymbolsFromDebuginfodCache(const char* build_id, int build_id_len);
     bool loadSymbolsUsingBuildId();
     bool loadSymbolsUsingDebugLink();
     void loadSymbolTable(const char* symbols, size_t total_size, size_t ent_size, const char* strings);
diff --git a/src/trap.cpp b/src/trap.cpp
@@ -46,7 +46,7 @@ void Trap::pair(Trap& second) {
 }
 
 // Patch instruction at the entry point
-bool Trap::patch(instruction_t insn) {
+bool Trap::patch(instruction_t insn) const {
     if (_unprotect) {
         int prot = WX_MEMORY ? (PROT_READ | PROT_WRITE) : (PROT_READ | PROT_WRITE | PROT_EXEC);
         if (OS::mprotect((void*)(_entry & -OS::page_size), OS::page_size, prot) != 0) {
diff --git a/src/trap.h b/src/trap.h
@@ -22,7 +22,7 @@ class Trap {
     instruction_t _breakpoint_insn;
     instruction_t _saved_insn;
 
-    bool patch(instruction_t insn);
+    bool patch(instruction_t insn) const;
 
     static uintptr_t _page_start[TRAP_COUNT];
 
diff --git a/src/wallClock.cpp b/src/wallClock.cpp
@@ -182,7 +182,7 @@ void WallClock::stop() {
     pthread_join(_thread, NULL);
 }
 
-void WallClock::timerLoop() {
+void WallClock::timerLoop() const {
     int self = OS::threadId();
     ThreadFilter* thread_filter = Profiler::instance()->threadFilter();
     bool thread_filter_enabled = thread_filter->enabled();
diff --git a/src/wallClock.h b/src/wallClock.h
@@ -28,7 +28,7 @@ class WallClock : public Engine {
     volatile bool _running;
     pthread_t _thread;
 
-    void timerLoop();
+    void timerLoop() const;
 
     static void* threadEntry(void* wall_clock) {
         ((WallClock*)wall_clock)->timerLoop();
