KEMBAR78
Guard more system headers by `FMT_MODULE` by yujincheng08 · Pull Request #4006 · fmtlib/fmt · GitHub
Skip to content

Conversation

@yujincheng08
Copy link
Contributor

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think we should use a single macro to make this cleaner when possible, e.g. FMT_MODULE (and set it if FMT_IMPORT_STD is defined).

@yujincheng08 yujincheng08 requested a review from vitaut June 13, 2024 13:58
@yujincheng08 yujincheng08 force-pushed the patch-3 branch 2 times, most recently from 485aef2 to c6f4208 Compare June 13, 2024 14:05
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall looks good, just minor comments inline.

@vitaut vitaut merged commit 8687315 into fmtlib:master Jun 14, 2024
@vitaut
Copy link
Contributor

vitaut commented Jun 14, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants