KEMBAR78
Mt complex p2197 r0 by tesch1 · Pull Request #4034 · fmtlib/fmt · GitHub
Skip to content

Conversation

@tesch1
Copy link

@tesch1 tesch1 commented Jun 25, 2024

This is not done, and probably not even good, but it's maybe a little better.

Probably need to re-think how to toggle iostreams compatibility, star or no star, and j or i.

Not sure if there's a way to get sign from the nested formatter?

@tesch1 tesch1 marked this pull request as draft June 25, 2024 04:10
@tesch1
Copy link
Author

tesch1 commented Jun 25, 2024

@vitaut
Copy link
Contributor

vitaut commented Jun 25, 2024

Not sure if there's a way to get sign from the nested formatter?

No, you'll need to parse it in the complex formatter.

@vitaut
Copy link
Contributor

vitaut commented Jul 2, 2024

@tesch1, do you plan to work on this in the nearest future? If not I will close the PR for now.

@tesch1
Copy link
Author

tesch1 commented Jul 3, 2024

perhaps not the nearest

@tesch1 tesch1 closed this Jul 3, 2024
@vitaut
Copy link
Contributor

vitaut commented Jul 3, 2024

It goes without saying that you are always welcome to open a new PR or reopen this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants