KEMBAR78
Added missing FMT_STRING in fmt::println(). by madmaxoft · Pull Request #4407 · fmtlib/fmt · GitHub
Skip to content

Added missing FMT_STRING in fmt::println(). #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Added missing FMT_STRING in fmt::println(). #4407

merged 1 commit into from
Apr 7, 2025

Conversation

@madmaxoft
Copy link
Contributor

The macro invocation is missing, breaking anything that uses fmt::println() in FMT_ENFORCE_COMPILE_STRING mode.

vitaut
vitaut requested changes Apr 6, 2025
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The change looks reasonable but please apply clang-format.

@madmaxoft madmaxoft force-pushed the FixFmtStringInPrintLn branch from 1fdfd0c to 9e4b058 Compare April 7, 2025 21:57
@vitaut vitaut merged commit 64db979 into fmtlib:master Apr 7, 2025
45 checks passed
@vitaut
Copy link
Contributor

vitaut commented Apr 7, 2025

Merged, thanks!

@madmaxoft madmaxoft deleted the FixFmtStringInPrintLn branch July 26, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitaut vitaut vitaut approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@madmaxoft @vitaut