KEMBAR78
ref: improve typing of sentry.db.models by asottile-sentry · Pull Request #72963 · getsentry/sentry · GitHub
Skip to content

ref: improve typing of sentry.db.models #72963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2024
Merged

ref: improve typing of sentry.db.models #72963

merged 1 commit into from
Jun 20, 2024

Conversation

@asottile-sentry
Copy link
Contributor

No description provided.

@asottile-sentry asottile-sentry requested review from a team June 18, 2024 19:45
@asottile-sentry asottile-sentry requested a review from a team as a code owner June 18, 2024 19:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 18, 2024
@asottile-sentry asottile-sentry requested a review from a team as a code owner June 18, 2024 20:03
@asottile-sentry asottile-sentry marked this pull request as draft June 18, 2024 20:08
@codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.48148% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.05%. Comparing base (8be6002) to head (11236e5).
Report is 2 commits behind head on master.

❗ Current head 11236e5 differs from pull request most recent head 29b9cc4

Please upload reports for the commit 29b9cc4 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #72963      +/-   ##
==========================================
+ Coverage   77.01%   78.05%   +1.04%     
==========================================
  Files        6616     6609       -7     
  Lines      295311   294860     -451     
  Branches    50887    50815      -72     
==========================================
+ Hits       227435   230159    +2724     
+ Misses      61533    58363    -3170     
+ Partials     6343     6338       -5
Files Coverage Δ
src/sentry/db/models/paranoia.py 100.00% <100.00%> (ø)
src/sentry/db/models/utils.py 91.83% <100.00%> (+11.83%) ⬆️
src/sentry/models/user.py 90.39% <100.00%> (-0.04%) ⬇️
src/sentry/db/models/query.py 66.66% <65.51%> (-1.47%) ⬇️

... and 934 files with indirect coverage changes

@asottile-sentry asottile-sentry force-pushed the asottile-typing-paranoia branch from 11236e5 to 29b9cc4 Compare June 20, 2024 13:40
@asottile-sentry asottile-sentry marked this pull request as ready for review June 20, 2024 13:40
@asottile-sentry asottile-sentry enabled auto-merge (squash) June 20, 2024 13:40
@asottile-sentry asottile-sentry merged commit 012d3f1 into master Jun 20, 2024
@asottile-sentry asottile-sentry deleted the asottile-typing-paranoia branch June 20, 2024 14:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanWoodard IanWoodard IanWoodard approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asottile-sentry @IanWoodard