ref: have models.User extend Model instead of BaseModel #72967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
most of our db helpers expected .id to be a Field[int, int] and use Model as the type for that
asottile-sentry
force-pushed
the
asottile-user-from-model-not-base-model
branch
from
7297c77 to
b3aa840
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72967 +/- ##
=======================================
Coverage 78.05% 78.05%
=======================================
Files 6610 6610
Lines 294851 294866 +15
Branches 50811 50817 +6
=======================================
+ Hits 230144 230159 +15
+ Misses 58369 58367 -2
- Partials 6338 6340 +2
|
markstory
approved these changes
Jun 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most of our db helpers expected .id to be a Field[int, int] and use Model as the type for that
no migration was generated so I believe this to be a fancy noop