KEMBAR78
Comparing ffac537e6c...b37e0ec32b · git/git · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: git/git
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ffac537e6c
Choose a base ref
...
head repository: git/git
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b37e0ec32b
Choose a head ref
  • 4 commits
  • 2 files changed
  • 2 contributors

Commits on May 19, 2019

  1. documentation: add tutorial for first contribution

    This tutorial covers how to add a new command to Git and, in the
    process, everything from cloning git/git to getting reviewed on the
    mailing list. It's meant for new contributors to go through
    interactively, learning the techniques generally used by the git/git
    development community.
    
    Reviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    Reviewed-by: Jonathan Tan <jonathantanmy@google.com>
    Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    nasamuffin authored and gitster committed May 19, 2019
    Configuration menu
    Copy the full SHA
    76644e3 View commit details
    Browse the repository at this point in the history
  2. documentation: add anchors to MyFirstContribution

    During the course of review for MyFirstContribution.txt, the suggestion
    came up to include anchors to make it easier for veteran contributors to
    link specific sections of this documents to newbies. To make life easier
    for reviewers, add these anchors in their own commit. See review context
    here: https://public-inbox.org/git/20190507195938.GD220818@google.com/
    
    AsciiDoc does not support :sectanchors: and the anchors are not
    discoverable, but they are referenceable. So a link to
    "foo.com/MyFirstContribution.html#prerequisites" will still work if that
    file was generated with AsciiDoc. The inclusion of :sectanchors: does
    not create warnings or errors while compiling directly with `asciidoc -b
    html5 Documentation/MyFirstContribution.txt` or while compiling with
    `make doc`.
    
    AsciiDoctor does support :sectanchors: and displays a paragraph link on
    mouseover. When the anchor is included above or inline with a section
    (as in this change), the link provided points to the custom ID contained
    within [[]] instead of to an autogenerated ID. Practically speaking,
    this means we have .../MyFirstContribution.html#summary instead of
    .../MyFirstContribution.html#_summary. In addition to being prettier,
    the custom IDs also enable anchor linking to work with
    asciidoc-generated pages. This change compiles with no warnings using
    `asciidoctor -b html5 Documentation/MyFirstContribution.txt`.
    
    Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    nasamuffin authored and gitster committed May 19, 2019
    Configuration menu
    Copy the full SHA
    5ef811a View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. doc: add some nit fixes to MyFirstContribution

    A trial run-through of the tutorial revealed a few typos and missing
    commands in the tutorial itself. This commit fixes typos, clarifies
    which lines to keep or modify in some places, and adds a section on
    putting the git-psuh binary into the gitignore.
    
    Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    nasamuffin authored and gitster committed May 29, 2019
    Configuration menu
    Copy the full SHA
    2656fb1 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. doc: improve usage string in MyFirstContribution

    We implement a command called git-psuh which accept arguments, so let's
    show that it accepts arguments in the doc and the usage string.
    
    While at it, we need to prepare "a NULL-terminated array of usage strings",
    not just "a NULL-terminated usage string".
    
    Helped-by: Emily Shaffer <emilyshaffer@google.com>
    Helped-by: Eric Sunshine <sunshine@sunshineco.com>
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    chriscool authored and gitster committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    b37e0ec View commit details
    Browse the repository at this point in the history
Loading