-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Mid-stage locking support #1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could do this automatically using reflection? This is faster for now.
Some refactoring to make it cleaner when doing this
This actually didn’t cause any decoding issues to leave old data at the end, but we should be efficient with on-disk data.
Key value store
Locking: move lock funcs to own package
This removes another implicit dependency on global config from API pkg
Locking / API package config usage refactor
API version currently has some fields which may go away, or which may be solely internal in future. For now only expose the fields which are always useful.
Implement local lock cache, support querying it
|
Thanks for opening this. All of the individual PRs in this series have looked good to me, but before we ship this package I want to figure out the I'm having the same concerns about my work in the |
|
Yeah I knew I needed to have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should go ahead and ship this to master. I too want to rethink how the api package works, but I don't want to keep both this and tq-master up in the air for too long.
This simply aggregates the following PRs:
This is a stable midpoint so is safe for
master;locking-masterwill continue afterwards with further review-friendly staging PRs on locking until more is ready for prime-time.