KEMBAR78
Mid-stage locking support by sinbad · Pull Request #1769 · git-lfs/git-lfs · GitHub
Skip to content

Conversation

sinbad
Copy link
Contributor

@sinbad sinbad commented Dec 14, 2016

This simply aggregates the following PRs:

This is a stable midpoint so is safe for master; locking-master will continue afterwards with further review-friendly staging PRs on locking until more is ready for prime-time.

Could do this automatically using reflection? This is faster for now.
Some refactoring to make it cleaner when doing this
This actually didn’t cause any decoding issues to leave old data at the
end, but we should be efficient with on-disk data.
Locking: move lock funcs to own package
This removes another implicit dependency on global config from API pkg
Locking / API package config usage refactor
@ttaylorr
Copy link
Contributor

Thanks for opening this. All of the individual PRs in this series have looked good to me, but before we ship this package I want to figure out the api vs locking package situation. Both of them have Lock structs, and api knows how to interact with HTTP stuff. I think locking should own everything up until making a network request.

I'm having the same concerns about my work in the tq package, so I am just about to start 🍐-ing with @technoweenie to figure out where things should go moving forward.

@sinbad
Copy link
Contributor Author

sinbad commented Dec 14, 2016

Yeah I knew I needed to have a Lock struct in locking, and I pared it down to the fields I know we need (client-facing), whereas internally there may be more info we need to deal with edge cases - you had a stab at that in the api package but right now I don't know if those will be the exact ones we'll have in the end. Perhaps we just standardise on the locking version for the moment and accept that the api fields will change (and can be implemented via composition or conversion as fits best) once we've fully explored what's needed for the full workflow.

Copy link
Contributor

@technoweenie technoweenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go ahead and ship this to master. I too want to rethink how the api package works, but I don't want to keep both this and tq-master up in the air for too long.

@technoweenie technoweenie merged commit bb8b02f into master Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants