Add --skip-repo option to git lfs install & use in tests
#1868
Conversation
Useful for avoiding unintended side effects when just wanting to install filters
Previously running any tests inside the `git-lfs` repo would create hooks which was undesirable (regardless of whether you use GIT_LFS_TEST_DIR or not). Gets worse the more hooks we add.
There was a problem hiding this comment.
The code looks good, and this is definitely a useful thing to have 👍
Before merging, I think we should talk about the name --skip-repo. It's awesome that it's documented in the manpage entry, but without consulting that first, I'm not immediately sure on what that flag means. What do you think about keeping a similar convention with the --skip-smudge flag and naming this new flag: --skip-all?
|
Names are hard 😄 I don't really like |
2 participants
It's bugged me for a while that the integration tests keep creating the
pre-pushhook in my localgit-lfsworking copy repo whenever I run them; it gets much worse when you factor in the new hooks we're starting to add. This happens even if you useGIT_LFS_TEST_DIR, if you run the tests from within the working copy.Seems useful to have a
--skip-repooption ingit lfs installwhich skips the local repo changes, for when you just want to install filters. This is how our tests need to use it.I could have just made the tests
cdto a non-repo folder instead but being explicit seems better.