commands/smudge: treat empty pointers as empty files #1954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request treats empty pointers as empty objects, and writes them out as such.
Previously, an empty pointer would be treated as malformed. An empty file would get written out, but the file would also be marked as belonging to a malformed pointer.
With this change, LFS counts the number of bytes spooled out to Git. If there was no error in spooling, and the number of bytes written is zero (meaning that we successfully wrote zero bytes with the intent to do so), return a nil error, instead of marking it as a malformed pointer.
/cc @git-lfs/core
/x-ref #1922