This repository was archived by the owner on Dec 15, 2020. It is now read-only.
Don't try using SEP keys if laptop is closed #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cut a new beta release with this change: https://github.com/github/SoftU2F/releases/tag/0.0.15-beta2 |
|
Nice polish! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS shows an annoying dialog when you try to sign something with a SEP backed key. This is especially annoying when you're using an external monitor with your laptop closed and can't get to the TouchID.
This PR checks if the laptop is open by iterating through the available displays and checking if any of them are builtin. If the laptop is closed, we abort the authentication request immediately.
/cc @ptoomey3 since we were talking about this yesterday.