KEMBAR78
Experimental query: ClipboardBasedXss by bananabr · Pull Request #6498 · github/codeql · GitHub
Skip to content

Conversation

@bananabr
Copy link
Contributor

This query looks for potential DomBasedXSS vulnerabilities whose source is the clipboard API. This source is not currently covered by the official XSS queries.

Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! Just a quick comment for now; a proper review will come later.

Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the submission @bananabr 👍

We'd be happy to merge the query like this. In the future we will most likely move the clipboard source into the js/xss-through-dom query.

bananabr and others added 2 commits August 25, 2021 09:40
Typo fix

Co-authored-by: Asger F <asgerf@github.com>
Simplifies query to improve performance by removing unnecessary results.
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@perovovao perovovao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [ ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants