KEMBAR78
Remove Travis-CI, use Golang 1.16 by timvaillancourt · Pull Request #140 · github/freno · GitHub
Skip to content

Remove Travis-CI, use Golang 1.16 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 11, 2021
Merged

Remove Travis-CI, use Golang 1.16 #140

merged 4 commits into from
May 11, 2021

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented May 11, 2021 •
edited
Loading

This PR removes Travis-CI builds and uses Golang 1.16

@timvaillancourt timvaillancourt temporarily deployed to staging May 11, 2021 15:29 Inactive
@timvaillancourt timvaillancourt requested review from gtowey and rashiq May 11, 2021 15:31
@timvaillancourt timvaillancourt marked this pull request as ready for review May 11, 2021 15:45
rashiq
rashiq reviewed May 11, 2021
View reviewed changes
@rashiq
Copy link
Member

rashiq commented May 11, 2021 •
edited
Loading

Looks good to me! there seems to be this https://github.com/github/freno/blob/master/internal/raft/.travis.yml file that I think we can also remove

@timvaillancourt
Copy link
Contributor Author

Looks good to me! there seems to be this https://github.com/github/freno/blob/master/internal/raft/.travis.yml file that I think we can also remove

I think I'll leave that because internal/raft is just a pseudo-vendored copy of Hashicorp's raft library and most vendored code includes extra files like this

@timvaillancourt timvaillancourt merged commit ede7322 into master May 11, 2021
@timvaillancourt timvaillancourt deleted the remove-travis branch May 11, 2021 17:23
@rashiq
Copy link
Member

rashiq commented May 11, 2021

Ah right right, I didn't realize that was a vendor file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rashiq rashiq rashiq approved these changes

@gtowey gtowey Awaiting requested review from gtowey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timvaillancourt @rashiq