KEMBAR78
Comparing v1.1.4...v1.1.5 · github/gh-ost · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: github/gh-ost
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.4
Choose a base ref
...
head repository: github/gh-ost
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.5
Choose a head ref
  • 15 commits
  • 35 files changed
  • 8 contributors

Commits on Jul 7, 2022

  1. Use .String() for logging connection-config InstanceKey

    @timvaillancourt
    timvaillancourt authored and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    9b27d91 View commit details
    Browse the repository at this point in the history

  2. Fix needless fmt.Sprintf call in go/logic/inspector.go

    @timvaillancourt
    timvaillancourt authored and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    869ed92 View commit details
    Browse the repository at this point in the history

  3. Add binaries for arm64 architectures

    @jecepeda
    jecepeda authored and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    63c171d View commit details
    Browse the repository at this point in the history

  4. Add golangci-lint CI action, fix gosimple, govet + unused lin… 

    …t errors (#1127)

* Add `golangci-lint`, fix `gosimple`, `govet` and `unused` linter complaints

* Go 1.16

* Update copyright dates
    @timvaillancourt
    timvaillancourt authored and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    8dd1571 View commit details
    Browse the repository at this point in the history

  5. Fix integer divide by zero panic in migrator

    @timvaillancourt
    timvaillancourt authored and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    6598b34 View commit details
    Browse the repository at this point in the history

  6. fix(lost data in mysql two-phase commit): lost data in mysql two-phas… 

    …e commit
    @shaohk
    shaohk authored and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    e0d31ba View commit details
    Browse the repository at this point in the history

  7. Run CodeQL analysis on PRs

    dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    fcda553 View commit details
    Browse the repository at this point in the history

  8. compound pk tests (#387) 

    * compound pk tests

* more details in failure diff

* more elaborate test; the pk-ts one consistently fails

* Fix merge conflict

Co-authored-by: Shlomi Noach <shlomi-noach@github.com>
Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @shlomi-noach @timvaillancourt
    4 people authored and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    9e0808a View commit details
    Browse the repository at this point in the history

  9. Ensure mysql rows responses are closed (#1132) 

    Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
    @timvaillancourt
    timvaillancourt and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    68b4085 View commit details
    Browse the repository at this point in the history

  10. Use switch statements for readability, simplify `.NewGoMySQLReader(… 

    …)` (#1135)

* Use `switch` statements for readability

* Simplify initBinlogReader()
    @timvaillancourt
    timvaillancourt authored and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b4566de View commit details
    Browse the repository at this point in the history

  11. Add context/timeout to HTTP throttle check (#1131) 

    * Add context/timeout to HTTP throttle check

* Dont run `.GetThrottleHTTPInterval()` on every loop

* Update help message

* Var rename

* 2022

* Add timeout flag

* Add unix/tcp server commands, use ParseInt() for string->int64

* Var rename

* Re-check http timeout on every loop iteration

* Remove stale comment

* Make throttle interval idempotent

* var rename

* Usage grammar

* Make http timeout idempotent too

* Parse time.Duration once

* Move timeout to NewThrottler

* Help update

* Set User-Agent header

* Re-add newline

Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
    @timvaillancourt
    timvaillancourt and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    614b379 View commit details
    Browse the repository at this point in the history

  12. Cancel any row count queries before attempting to cut over (#846) 

    * Cancel any row count queries before attempting to cut over

Closes #830. Switches from using `QueryRow` to `QueryRowContext`, and
stores a context.CancelFunc in the migration context, which is called to
halt any running row count query before beginning the cut over.

* Make it threadsafe

* Kill the count query on the database side as well

* Explicitly grab a connection to run the count, store its connection id
* When the query context is canceled, run a `KILL QUERY ?` on that connection id

* Rewrite these to use the threadsafe functions, stop exporting the cancel func

* Update logger

* Update logger

Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
    @ajm188 @timvaillancourt
    4 people committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    3e72f1b View commit details
    Browse the repository at this point in the history

  13. v1.1.5

    dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    0adb697 View commit details
    Browse the repository at this point in the history

  14. Check RowsAffected when applying DML events to get more accurate stat… 

    …istics (#844)

* Check RowsAffected when applying DML events to get more accurate statistics

Addresses #600.

When applying a DML event, check the RowsAffected on the `Result`
struct. Since all DML event queries are point queries, this will only
ever be 0 or 1. The applier then takes this value and multiplies by
the `rowsDelta` of the event, resulting in a properly-signed, accurate
row delta to use in the statistics.

If an error occurs here, log it, but do not surface this as an
actual error .. simply assume the DML affected a row and move on. It
will be inaccurate, but this is already the case.

* Fix import

* update wording to warning log message

Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>
    @ajm188 @timvaillancourt
    2 people authored and dm-2 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    f29e63b View commit details
    Browse the repository at this point in the history

  15. vendor github.com/openark/golib

    dm-2 committed Jul 7, 2022
    1 Configuration menu
    Copy the full SHA
    f2c2033 View commit details
    Browse the repository at this point in the history
Loading