Support a complete ALTER TABLE statement in --alter #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did intend to first open this PR against https://github.com/openark/gh-ost ; but hit the wrong button... Since we're already here, I'm also happy to submit it upstream. |
timvaillancourt
approved these changes
Aug 13, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports a complete
ALTER TABLEstatement in--altercommand line argument.Until this PR, if one wanted to run a
ALTER TABLE my_schema.my_table DROP COLUMN b, one would have to rungh-ostwith:--database=my_schema--table=my_table--alter="DROP COLUMN b"Starting this PR,
gh-ostcan deduce schema and table names from the--alterstatement. It's now valid to:--ALTER="ALTER TABLE my_schema.my_table DROP COLUMN b"as well as:
--database=my_schema --ALTER="ALTER TABLE my_table DROP COLUMN b"