KEMBAR78
Upgrade to Go 1.23.4 by rolandshoemaker · Pull Request #12912 · google/oss-fuzz · GitHub
Skip to content

Upgrade to Go 1.23.4 #12912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2025
Merged

Upgrade to Go 1.23.4 #12912

merged 2 commits into from
Jan 8, 2025

Conversation

@rolandshoemaker
Copy link
Contributor

Additionally, don't override the go.mod version for the http2/hc fuzz case.

This fixes a handfull of build failures in the golang project.

@github-actions
Copy link

github-actions bot commented Jan 7, 2025

rolandshoemaker is either the primary contact or is in the CCs list of projects/golang.
rolandshoemaker has previously contributed to projects/golang. The previous PR was #11663

@AdamKorcz
Copy link
Collaborator

Thanks @rolandshoemaker I fixed the Golang build yesterday with #12908.

Closing.

@AdamKorcz AdamKorcz closed this Jan 7, 2025
@AdamKorcz
Copy link
Collaborator

We can merge your changes in infra/base-images/base-builder/install_go.sh. Can you rebase and discard the changes in projects/golang/build.sh?

@AdamKorcz AdamKorcz reopened this Jan 7, 2025
@rolandshoemaker
Upgrade to Go 1.23.4
4540125 
Upgrade the base Go installation to 1.23.4.
@rolandshoemaker
Copy link
Contributor Author

@AdamKorcz Ah, I missed your change, thanks for that!

I don't think this change is strictly necessary now, but it's probably good to keep the base Go installation in sync. Reverted the projects/golang/build.sh changes.

@DavidKorczynski
Copy link
Collaborator

/gcbrun trial_build.py go --fuzzing-engines libfuzzer --sanitizers coverage address

@DavidKorczynski
Copy link
Collaborator

This looks good, two projects fail, dgraph which is unrelated to this PR and now fixed in #12920 and cockroachdb which @AdamKorcz will create a PR to fix following this. This is good to go.

@DavidKorczynski DavidKorczynski merged commit 530e34d into google:master Jan 8, 2025
18 of 19 checks passed
@AdamKorcz AdamKorcz mentioned this pull request Jan 8, 2025
Merged
DavidKorczynski pushed a commit that referenced this pull request Jan 8, 2025
@AdamKorcz
cockroachdb: use go 1.22 (#12922)
5abfe35 
Fixes
#12912 (comment)

Signed-off-by: Adam Korczynski <adam@adalogics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidKorczynski DavidKorczynski DavidKorczynski approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rolandshoemaker @AdamKorcz @DavidKorczynski