KEMBAR78
feat: adds universe domain for DownscopedCredentials and ExternalAccountAuthorizedUserCredentials by lsirac · Pull Request #1355 · googleapis/google-auth-library-java · GitHub
Skip to content

feat: adds universe domain for DownscopedCredentials and ExternalAccountAuthorizedUserCredentials #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 25, 2024
Merged

feat: adds universe domain for DownscopedCredentials and ExternalAccountAuthorizedUserCredentials #1355

merged 11 commits into from
Jan 25, 2024

Conversation

@lsirac
Copy link
Contributor

@lsirac lsirac commented Jan 18, 2024

  • Adds universe domain support for DownscopedCredentials.
  • Adds universe domain support for ExternalAccountAuthorizedUserCredentials.
  • Adds more tests for universe domain in the BYOID credential classes.

@lsirac lsirac requested review from a team as code owners January 18, 2024 00:48
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 18, 2024
@lsirac lsirac added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 18, 2024
@TimurSadykov TimurSadykov self-requested a review January 20, 2024 00:54
@TimurSadykov
Copy link

looking

TimurSadykov
TimurSadykov suggested changes Jan 22, 2024
View reviewed changes
aeitzman
aeitzman approved these changes Jan 23, 2024
View reviewed changes
TimurSadykov
TimurSadykov approved these changes Jan 24, 2024
View reviewed changes
Copy link

@TimurSadykov TimurSadykov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one test suggestions

@lsirac lsirac removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 24, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lsirac lsirac merged commit 17ef707 into googleapis:main Jan 25, 2024
@release-please release-please bot mentioned this pull request Jan 25, 2024
Merged
@lsirac lsirac deleted the downscoped branch January 25, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TimurSadykov TimurSadykov TimurSadykov approved these changes

@aeitzman aeitzman aeitzman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsirac @TimurSadykov @aeitzman