fix(bigquery): cache total rows count #12230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
shollyman
approved these changes
May 9, 2025
alvarowolfx
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
2FaceS-bit
pushed a commit
to 2FaceS-bit/google-cloud-go
that referenced
this pull request
May 12, 2025
Total rows on fast query path was using the amount of rows returned on the first page, which was incorrect for result sets with multiple pages. Supersedes googleapis#11874 Fixes googleapis#11873
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 12, 2025
🤖 I have created a release *beep* *boop* --- ## [1.68.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.67.0...bigquery/v1.68.0) (2025-05-12) ### Features * **bigquery/analyticshub:** Support new feature Sharing Cloud Pubsub Streams via AH (GA) and Subscriber Email logging feature ([#11908](https://togithub.com/googleapis/google-cloud-go/issues/11908)) ([a21d596](https://togithub.com/googleapis/google-cloud-go/commit/a21d5965fa3f4322da9563425350ba1079279d5a)) * **bigquery/storage:** Increased the number of partitions can be written in a single request ([43bc515](https://togithub.com/googleapis/google-cloud-go/commit/43bc51591e4ffe7efc76449bb00e3747cda2c944)) * **bigquery:** Add performance insights ([#12101](https://togithub.com/googleapis/google-cloud-go/issues/12101)) ([aef68ab](https://togithub.com/googleapis/google-cloud-go/commit/aef68abaa336e0ecd1f488ef6cb3d6b0e8930835)) * **bigquery:** Add some missing fields to BQ stats ([#12212](https://togithub.com/googleapis/google-cloud-go/issues/12212)) ([77b08e8](https://togithub.com/googleapis/google-cloud-go/commit/77b08e8e72ece0d56ff8f86dcbfe44b944ab083f)) * **bigquery:** Add WriteTruncateData write disposition ([#12013](https://togithub.com/googleapis/google-cloud-go/issues/12013)) ([b1126a3](https://togithub.com/googleapis/google-cloud-go/commit/b1126a3580a0c81c1d7df7cf138d17c748adefbc)) * **bigquery:** New client(s) ([#12228](https://togithub.com/googleapis/google-cloud-go/issues/12228)) ([f229bd9](https://togithub.com/googleapis/google-cloud-go/commit/f229bd9b90830d96781d3f9059b64dbfece1690b)) * **bigquery:** Support managed iceberg tables ([#11931](https://togithub.com/googleapis/google-cloud-go/issues/11931)) ([35e0774](https://togithub.com/googleapis/google-cloud-go/commit/35e0774bf17166dbaa88eba286f40ad91d9aa68a)) * **bigquery:** Support per-job reservation assignment ([#12078](https://togithub.com/googleapis/google-cloud-go/issues/12078)) ([c9cebcc](https://togithub.com/googleapis/google-cloud-go/commit/c9cebcceebc5fb5eecacf99e18652e0c2a53cc6c)) ### Bug Fixes * **bigquery:** Cache total rows count ([#12230](https://togithub.com/googleapis/google-cloud-go/issues/12230)) ([202dce0](https://togithub.com/googleapis/google-cloud-go/commit/202dce02888c5d1d2821732145d5780e5c07ba05)), refs [#11874](https://togithub.com/googleapis/google-cloud-go/issues/11874) [#11873](https://togithub.com/googleapis/google-cloud-go/issues/11873) * **bigquery:** Parse timestamps with timezone info ([#11950](https://togithub.com/googleapis/google-cloud-go/issues/11950)) ([530d522](https://togithub.com/googleapis/google-cloud-go/commit/530d522a1f8622e51310680cce31ff1dae007f81)) * **bigquery:** Update google.golang.org/api to 0.229.0 ([3319672](https://togithub.com/googleapis/google-cloud-go/commit/3319672f3dba84a7150772ccb5433e02dab7e201)) * **bigquery:** Upgrade gRPC service registration func ([7c01015](https://togithub.com/googleapis/google-cloud-go/commit/7c01015f2aafb5eeb0237accced76b059bc7635d)) ### Documentation * **bigquery/storage:** Updated the number of partitions (from 100 to 900) can be inserted, updated and deleted in a single request ([43bc515](https://togithub.com/googleapis/google-cloud-go/commit/43bc51591e4ffe7efc76449bb00e3747cda2c944)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Total rows on fast query path was using the amount of rows returned on the first page, which was incorrect for result sets with multiple pages.
Supersedes #11874
Fixes #11873