KEMBAR78
fix(test): update test tokens by diegomarquezp · Pull Request #953 · googleapis/google-oauth-java-client · GitHub
Skip to content

Conversation

@diegomarquezp
Copy link
Contributor

added a special method to use independent clocks the token timeout check passes for each token

Fixes #950

@diegomarquezp diegomarquezp requested a review from a team as a code owner October 6, 2022 21:31
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 6, 2022
@google-cla
Copy link

google-cla bot commented Oct 6, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

added a special method to use independent clocks the token timeout check
passes for each token
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@diegomarquezp diegomarquezp merged commit d523410 into main Oct 8, 2022
@diegomarquezp diegomarquezp deleted the fix-id-verifier branch October 8, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IdTokenVerifierTest.testVerifyServiceAccountRs256Token:331 » IO Could not find public key for provided keyId [KEY]

2 participants