feat(bigquery): Support resource tags for datasets in java client #3647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
|
Spoke offline with @shollyman and we decided that integration testing with my personal test project was sufficient as we could not find a way to create tags in the kokoro test environment. See comment above for the sister PR that includes the integration tests. |
whuffman36
requested review from
PhongChuong,
alvarowolfx and
shollyman
and removed request for
alvarowolfx
PhongChuong
approved these changes
Jan 28, 2025
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the resource tag feature from bigquery in the java client library. See doc here
Integration tests for this change can be found at this PR draft. These tests fail in the kokoro environment because we are not able to able to add tags to the project due to lack of permissions. The integration tests pass in my personal cloud project as I have permissions to create and edit tags in my own project.