KEMBAR78
docs: update error handling comment to be more precise in samples by PhongChuong · Pull Request #3712 · googleapis/java-bigquery · GitHub
Skip to content

docs: update error handling comment to be more precise in samples #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 12, 2025
Merged

docs: update error handling comment to be more precise in samples #3712

merged 6 commits into from
Mar 12, 2025

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Mar 6, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes # b/400931542

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Mar 6, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 6, 2025
@PhongChuong PhongChuong marked this pull request as ready for review March 6, 2025 16:14
shollyman
shollyman approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make the implication stronger that the stream may represent warnings rather than terminal errors, otherwise LGTM

@PhongChuong PhongChuong requested review from a team as code owners March 12, 2025 18:57
@PhongChuong
Copy link
Contributor Author

Updated the comment slightly.
Thank you for the review.

@PhongChuong PhongChuong merged commit 9eb555f into main Mar 12, 2025
17 checks passed
@PhongChuong PhongChuong deleted the b400931542 branch March 12, 2025 19:23
@release-please release-please bot mentioned this pull request Mar 11, 2025
Merged
This was referenced Mar 25, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

@whuffman36 whuffman36 Awaiting requested review from whuffman36

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PhongChuong @shollyman