samples: Fixes #1051 #1053
Merged
samples: Fixes #1051 #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passed updated view definition to bigquery.update() method.
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
samples
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
=========================================
Coverage 80.18% 80.18%
Complexity 1268 1268
=========================================
Files 79 79
Lines 6576 6576
Branches 760 761 +1
=========================================
Hits 5273 5273
Misses 910 910
Partials 393 393 Continue to review full report at Codecov.
|
stephaniewang526
approved these changes
Jan 11, 2021
stephaniewang526
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
|
@stephaniewang526 I checked the documentation at https://cloud.google.com/bigquery/docs/updating-views#update-sql and it shows code snippet prior to this commit. Do I need to update documentation separately? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed updated view definition to bigquery.update() method.
Fixes #1051 ☕️